Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Generate proto with go generate only if proto tag is provided #411

Closed
wants to merge 1 commit into from

Conversation

3v1n0
Copy link
Collaborator

@3v1n0 3v1n0 commented Jul 3, 2024

Avoids generating proto files unless explicitly requested.

As per this it's now an error if the generation script is called during package build.

UDENG-3507

@3v1n0 3v1n0 requested a review from a team as a code owner July 3, 2024 15:01
Avoids generating proto files unless explicitly requested.

As per this it's now an error if the generation script is called during
package build.
Copy link
Member

@didrocks didrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think we want that.

go generate should always generate as per description. We should skip the generation during package build.

Then, we are using generate here to build the pam module, which is wrong and should be in the debian/rules makefile. We may need to add a build system for nss/pam in the future, but not for now.

@3v1n0
Copy link
Collaborator Author

3v1n0 commented Jul 3, 2024

So, you prefer the status quo better?

I'm fine either way... Indeed we could build the module differently, but in the past it was built this way and during the various iterations we've always kept the ability to build the module in a single way everywhere, so that we had not to control too many ways to build it.

Personally I agree we should have a proper build system for such things.

@3v1n0 3v1n0 closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants